]> dgit.raspbian.org Git - gnome-shell.git/commit
windowManager: Check whether metaWindow is NULL after destroy animation
authorJonas Dreßler <verdre@v0yd.nl>
Sat, 24 Oct 2020 20:24:35 +0000 (22:24 +0200)
committerJonas Dreßler <verdre@v0yd.nl>
Sat, 21 Nov 2020 22:40:53 +0000 (23:40 +0100)
commit96dc6d19dd30ec6dcac375de6811401012e77369
tree01ce8534824e3e2f03ddb3696a3dac6897935031
parent07fd0d3f2e5f111cf664da701c65f0bb56947fb5
windowManager: Check whether metaWindow is NULL after destroy animation

When logging out or terminating gnome-shell, mutter will unmanage all
open windows, triggering the window-close animation in gnome-shell and
very quickly after that emitting "kill-window-effects". That means we'll
call _destroyWindowDone() to cleanup our animation data, but at this
point the MetaWindow of the window is already gone, so we get an error
that get_meta_window() returns NULL.

Fix that by checking whether get_meta_window() returned NULL and if it
did, don't access the window.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2018

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1483>
js/ui/windowManager.js